Skip to content

Remove local runtime#1602

Merged
ipapandinas merged 5 commits intomasterfrom
remove-local-runtime
Mar 12, 2026
Merged

Remove local runtime#1602
ipapandinas merged 5 commits intomasterfrom
remove-local-runtime

Conversation

@ipapandinas
Copy link
Contributor

@ipapandinas ipapandinas commented Mar 9, 2026 •
edited
Loading

Pull Request Summary

Closes #1567

This PR removes local runtime and makes local dev node parachain-oriented using Shibuya runtime. It removes grandpa, uses aura manual-sealing consensus by default and mocks relay chain validation similar to what polkadot-omni node is doing.

Frontier tests were updated accordingly AstarNetwork/frontier-tests#3

@ipapandinas ipapandinas added the client This PR/Issue is related to the topic “client”. label Mar 9, 2026
@ipapandinas ipapandinas mentioned this pull request Mar 9, 2026
Closed
Dinonard
Dinonard previously approved these changes Mar 10, 2026
View reviewed changes
Copy link
Contributor

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't do a super detailed review, but LGTM.

If runtime upgrade works, and sending XCM doesn't brick the chain (?), let's merge it.

@ipapandinas
Copy link
Contributor Author

ipapandinas commented Mar 10, 2026

@Dinonard Actually, I've increased the max_code_size to 16Mb. It's 2Mb by default and Shibuya runtime 2101 is ~2,7Mb. Sending XCM doesn't brick the chain, it fails safely. Perhaps the mock could be extended in the future to handle it if the need arises.

@Dinonard
Copy link
Contributor

Dinonard commented Mar 10, 2026

@Dinonard Actually, I've increased the max_code_size to 16Mb. It's 2Mb by default and Shibuya runtime 2101 is ~2,7Mb. Sending XCM doesn't brick the chain, it fails safely. Perhaps the mock could be extended in the future to handle it if the need arises.

Best to keep it as simple as possible.
As long as XCM doesn't crash, and we can do all the other actions normally, it should be good.

Dinonard
Dinonard previously approved these changes Mar 11, 2026
View reviewed changes
ermalkaleci
ermalkaleci previously approved these changes Mar 11, 2026
View reviewed changes
@ipapandinas ipapandinas dismissed stale reviews from ermalkaleci and Dinonard via d197735 March 11, 2026 13:13
@github-actions
Copy link

github-actions bot commented Mar 11, 2026

Code Coverage

Package Line Rate Branch Rate Health
pallets/unified-accounts/src 80% 0% ✔
pallets/dapp-staking/src/test 0% 0% ❌
pallets/astar-xcm-benchmarks/src/generic 100% 0% ✔
precompiles/dapp-staking/src/test 0% 0% ❌
pallets/astar-xcm-benchmarks/src/fungible 100% 0% ✔
precompiles/assets-erc20/src 77% 0% ➖
pallets/vesting-mbm/src 87% 0% ✔
pallets/ethereum-checked/src 76% 0% ➖
pallets/dynamic-evm-base-fee/src 85% 0% ✔
pallets/xc-asset-config/src 57% 0% ➖
pallets/collator-selection/src 82% 0% ✔
precompiles/dapp-staking/src 89% 0% ✔
pallets/collective-proxy/src 94% 0% ✔
chain-extensions/types/unified-accounts/src 0% 0% ❌
pallets/astar-xcm-benchmarks/src 86% 0% ✔
chain-extensions/types/assets/src 0% 0% ❌
chain-extensions/unified-accounts/src 0% 0% ❌
precompiles/dispatch-lockdrop/src 89% 0% ✔
primitives/src/xcm 66% 0% ➖
pallets/dapp-staking/src/benchmarking 95% 0% ✔
precompiles/substrate-ecdsa/src 74% 0% ➖
primitives/src 55% 0% ➖
pallets/dapp-staking/rpc/runtime-api/src 0% 0% ❌
pallets/dapp-staking/src 77% 0% ➖
precompiles/sr25519/src 69% 0% ➖
pallets/price-aggregator/src 75% 0% ➖
precompiles/unified-accounts/src 100% 0% ✔
pallets/inflation/src 58% 0% ➖
precompiles/xcm/src 69% 0% ➖
pallets/static-price-provider/src 91% 0% ✔
chain-extensions/pallet-assets/src 55% 0% ➖
pallets/democracy-mbm/src 30% 0% ❌
Summary 71% (3851 / 5415) 0% (0 / 0) ➖

Minimum allowed line rate is 50%

@ipapandinas ipapandinas merged commit 13cbbee into master Mar 12, 2026
8 checks passed
@ipapandinas ipapandinas deleted the remove-local-runtime branch March 12, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dinonard Dinonard Dinonard approved these changes

@ermalkaleci ermalkaleci ermalkaleci approved these changes

Assignees

No one assigned

Labels

client This PR/Issue is related to the topic “client”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Local runtime removal

3 participants

@ipapandinas @Dinonard @ermalkaleci